Convert HTTP 302 responses to more-accurate 303.

This commit is contained in:
Patrick Fairbank
2017-09-02 14:08:16 -07:00
parent 13dd9dbb42
commit 4e418434da
17 changed files with 58 additions and 58 deletions

View File

@@ -29,7 +29,7 @@ func TestSetupAllianceSelection(t *testing.T) {
// Start the alliance selection.
recorder = web.postHttpResponse("/setup/alliance_selection/start", "")
assert.Equal(t, 302, recorder.Code)
assert.Equal(t, 303, recorder.Code)
if assert.Equal(t, 15, len(cachedAlliances)) {
assert.Equal(t, 4, len(cachedAlliances[0]))
}
@@ -39,20 +39,20 @@ func TestSetupAllianceSelection(t *testing.T) {
// Reset the alliance selection.
recorder = web.postHttpResponse("/setup/alliance_selection/reset", "")
assert.Equal(t, 302, recorder.Code)
assert.Equal(t, 303, recorder.Code)
assert.NotContains(t, recorder.Body.String(), "Captain")
assert.NotContains(t, recorder.Body.String(), ">110<")
web.arena.EventSettings.NumElimAlliances = 3
web.arena.EventSettings.SelectionRound3Order = ""
recorder = web.postHttpResponse("/setup/alliance_selection/start", "")
assert.Equal(t, 302, recorder.Code)
assert.Equal(t, 303, recorder.Code)
if assert.Equal(t, 3, len(cachedAlliances)) {
assert.Equal(t, 3, len(cachedAlliances[0]))
}
// Update one team at a time.
recorder = web.postHttpResponse("/setup/alliance_selection", "selection0_0=110")
assert.Equal(t, 302, recorder.Code)
assert.Equal(t, 303, recorder.Code)
assert.Equal(t, 110, cachedAlliances[0][0].TeamId)
recorder = web.getHttpResponse("/setup/alliance_selection")
assert.Contains(t, recorder.Body.String(), "\"110\"")
@@ -60,7 +60,7 @@ func TestSetupAllianceSelection(t *testing.T) {
// Update multiple teams at a time.
recorder = web.postHttpResponse("/setup/alliance_selection", "selection0_0=101&selection0_1=102&selection1_0=103")
assert.Equal(t, 302, recorder.Code)
assert.Equal(t, 303, recorder.Code)
assert.Equal(t, 101, cachedAlliances[0][0].TeamId)
assert.Equal(t, 102, cachedAlliances[0][1].TeamId)
assert.Equal(t, 103, cachedAlliances[1][0].TeamId)
@@ -71,14 +71,14 @@ func TestSetupAllianceSelection(t *testing.T) {
recorder = web.postHttpResponse("/setup/alliance_selection", "selection0_0=101&selection0_1=102&"+
"selection0_2=103&selection1_0=104&selection1_1=105&selection1_2=106&selection2_0=107&selection2_1=108&"+
"selection2_2=109")
assert.Equal(t, 302, recorder.Code)
assert.Equal(t, 303, recorder.Code)
recorder = web.getHttpResponse("/setup/alliance_selection")
assert.Contains(t, recorder.Body.String(), ">110<")
// Finalize alliance selection.
web.arena.Database.CreateTeam(&model.Team{Id: 254, YellowCard: true})
recorder = web.postHttpResponse("/setup/alliance_selection/finalize", "startTime=2014-01-01 01:00:00 PM")
assert.Equal(t, 302, recorder.Code)
assert.Equal(t, 303, recorder.Code)
alliances, err := web.arena.Database.GetAllAlliances()
assert.Nil(t, err)
if assert.Equal(t, 3, len(alliances)) {
@@ -105,7 +105,7 @@ func TestSetupAllianceSelectionErrors(t *testing.T) {
// Start an alliance selection that is already underway.
recorder := web.postHttpResponse("/setup/alliance_selection/start", "")
assert.Equal(t, 302, recorder.Code)
assert.Equal(t, 303, recorder.Code)
recorder = web.postHttpResponse("/setup/alliance_selection/start", "")
assert.Equal(t, 200, recorder.Code)
assert.Contains(t, recorder.Body.String(), "already in progress")
@@ -128,7 +128,7 @@ func TestSetupAllianceSelectionErrors(t *testing.T) {
assert.Contains(t, recorder.Body.String(), "until all spots have been filled")
recorder = web.postHttpResponse("/setup/alliance_selection", "selection0_0=101&selection0_1=102&"+
"selection0_2=103&selection1_0=104&selection1_1=105&selection1_2=106")
assert.Equal(t, 302, recorder.Code)
assert.Equal(t, 303, recorder.Code)
recorder = web.postHttpResponse("/setup/alliance_selection/finalize", "startTime=asdf")
assert.Equal(t, 200, recorder.Code)
assert.Contains(t, recorder.Body.String(), "valid start time")
@@ -168,7 +168,7 @@ func TestSetupAllianceSelectionAutofocus(t *testing.T) {
web.arena.EventSettings.SelectionRound2Order = "F"
web.arena.EventSettings.SelectionRound3Order = "F"
recorder := web.postHttpResponse("/setup/alliance_selection/start", "")
assert.Equal(t, 302, recorder.Code)
assert.Equal(t, 303, recorder.Code)
i, j := web.determineNextCell()
assert.Equal(t, 0, i)
assert.Equal(t, 0, j)
@@ -209,9 +209,9 @@ func TestSetupAllianceSelectionAutofocus(t *testing.T) {
web.arena.EventSettings.SelectionRound2Order = "L"
web.arena.EventSettings.SelectionRound3Order = "L"
recorder = web.postHttpResponse("/setup/alliance_selection/reset", "")
assert.Equal(t, 302, recorder.Code)
assert.Equal(t, 303, recorder.Code)
recorder = web.postHttpResponse("/setup/alliance_selection/start", "")
assert.Equal(t, 302, recorder.Code)
assert.Equal(t, 303, recorder.Code)
i, j = web.determineNextCell()
assert.Equal(t, 0, i)
assert.Equal(t, 0, j)